Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emac-drivers): Remove incorrect RMII RX ER initialization for STM targets #15349

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

akiroz
Copy link
Contributor

@akiroz akiroz commented Nov 20, 2022

Summary of changes

Fixes #15348

ST Nucleo MB1137: Signal not routed (Ref: DocID028599 Rev 7)

  • TARGET_NUCLEO_F207ZG
  • TARGET_NUCLEO_F429ZI
  • TARGET_NUCLEO_F439ZI
  • TARGET_NUCLEO_F746ZG
  • TARGET_NUCLEO_F756ZG
  • TARGET_NUCLEO_F767ZI

ST 32F746GDISCOVERY: RX_ER signal is on PB10/PI10 not PG2 (Ref: DocID027590 Rev 4)

  • TARGET_DISCO_F746NG

ST 32F746GDISCOVERY: RX_ER signal is on PB10/PI10 not PD5 (Ref: DS11532 Rev 7)

  • TARGET_DISCO_F769NI

ublox EVK-ODIN-W2: Signal not routed (Ref: UBX-16007132 - R07)

  • TARGET_MODULE_UBLOX_ODIN_W2

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested a review from a team November 20, 2022 08:30
@ciarmcom
Copy link
Member

@akiroz, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Nov 21, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 6, 2022

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 6, 2022

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@jeromecoutant
Copy link
Collaborator

Test run: FAILED

* jenkins-ci/mbed-os-ci_greentea-test-lts

All tests (including tests-netsocket-tcp/udp) are OK except tests-netsocket-tls
@0xc0170 is it possible something went wrong in the CI ?

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 6, 2022

I've seen it once in the last days, most likely local network hiccup, I'll restart and keep watching.

@mbed-ci
Copy link

mbed-ci commented Dec 6, 2022

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@jeromecoutant
Copy link
Collaborator

@akiroz Maybe you could propose a path on top of master ?
Thx

@jeromecoutant
Copy link
Collaborator

Test is failing in master branch...

@0xc0170 Is echo.mbedcloudtesting.com server still have the TLS port ?

@akiroz
Copy link
Contributor Author

akiroz commented Dec 15, 2022

@akiroz Maybe you could propose a path on top of master ? Thx

@jeromecoutant Should I create a new PR for master if I want the changes in both mbed 5 and 6?

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 16, 2022

@jeromecoutant Should I create a new PR for master if I want the changes in both mbed 5 and 6?

Yes please

@mbed-ci
Copy link

mbed-ci commented Dec 19, 2022

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@saheerb
Copy link
Contributor

saheerb commented Feb 1, 2023

@akiroz We will look into the jenkins-ci/example-test-lts failure. Mean while, could you please update the SPDX like in #15358

@akiroz
Copy link
Contributor Author

akiroz commented Feb 1, 2023

SPDX identifiers added

@mergify mergify bot dismissed 0xc0170’s stale review February 1, 2023 15:13

Pull request has been modified.

@mbed-ci
Copy link

mbed-ci commented Feb 9, 2023

Test run: SUCCESS

Summary: 9 of 9 test jobs passed
Build number : 4
Build artifacts

@saheerb saheerb merged commit 1a96e6a into ARMmbed:mbed-os-5.15 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants