-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the flame_wave
flame front analysis scripts
#3030
Open
yut23
wants to merge
6
commits into
AMReX-Astro:development
Choose a base branch
from
yut23:front_tracker_fixes
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dataset processing can run in parallel * added code to make interactive plots of each dataset that show the raw slice data, the averaged profile, and the positions for each metric * metric thresholds are calculated using both the local maximum and global maximum at the same time (under `<field>[<fac>%]` and `<field>[<fac>%]_gmax`, respectively) * the local maximum for each field is stored in the output file, in the `max_<field>` column * if a field value never goes below the threshold for a metric, its position will be stored as NaN * --[xyz]lim arguments now work, despite some yt bugs * allow ignoring plotfiles after a certain time with --tmax * default FRB resolution is set to match the finest level, and is automatically adjusted if custom limits are used
Now takes min and max times for the linear regression as optional arguments, and can plot multiple metrics at the same time.
zingale
approved these changes
Feb 7, 2025
The missing checks might be because I opened this PR against main initially. I just ran codespell locally, and it didn't find anything. |
I'm fine with it. You can merge if you want. |
abffb07
to
ced31a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
front_tracker.py
<field>[<fac>%]
and<field>[<fac>%]_gmax
, respectively)max_<field>
columnflame_speed.py
Now takes min and max times for the linear regression as optional arguments, and can plot multiple metrics at the same time.
PR checklist
CHANGES
file has been updated, if appropriate