Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some suggestions for an alternative implementation of traintest #37

Merged
merged 4 commits into from
Jul 1, 2022
Merged

Some suggestions for an alternative implementation of traintest #37

merged 4 commits into from
Jul 1, 2022

Conversation

Peter9192
Copy link
Contributor

@Peter9192 Peter9192 commented Jun 30, 2022 •
edited
Loading

Discussion points:

  • What to do with 'flat' keyword?
  • Executing train/test only once
  • Do as little as possible in 'traintest.py'?
  • ...

How to use:

import s2s.time
cal = s2s.time.AdventCalendar((1, 31))
cal.map_years(2019, 2022)
cal.set_traintest_method('kfold', n_splits=2)
cal.traintest

@Peter9192
Copy link
Contributor Author

Todo:

  • Fix tests
  • Update docstrings

Feel free to merge into your own feature branch and continue working on it there.

@Peter9192 Peter9192 marked this pull request as ready for review June 30, 2022 09:12
@Peter9192 Peter9192 requested a review from geek-yang June 30, 2022 09:13
geek-yang
geek-yang approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@geek-yang geek-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions! The code looks quite light-weight now. There is only one minor issue related to the display of calendar in the notebook. I will address it in PR #23 after merging this PR to it.

@geek-yang geek-yang merged commit 29da72f into implement_traintest Jul 1, 2022
@geek-yang geek-yang deleted the suggestion branch July 1, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geek-yang geek-yang geek-yang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peter9192 @geek-yang