Random default emoji! #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengerman13
reviewed
Sep 24, 2024
src/scripts/random-responses.js
Outdated
| // If it's a list, pick one at random. | ||
| if (Array.isArray(defaultEmoji)) { | ||
| message.icon_emoji = | ||
| defaultEmoji[Math.floor(Math.random() * defaultEmoji.length)]; |
There was a problem hiding this comment.
what happens if defaultEmoji is an array with length 0?
There was a problem hiding this comment.
(...now, anyway)
bengerman13
approved these changes
Sep 25, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be super neat if our random responses could define a random emoji to be used when posting them. This PR makes that so. Screambot will be in for such a delightful update.
Checklist:
The OAuth wikipage has been updated if Charlie needs any new OAuth events or scopes
The Environment Variableswiki page has been updated if new environment variables were introduced
or existing ones changed
major development workflows have changedinternal utilities or APIs have changedtesting or deployment processes have changedIf appropriate, the NIST 800-218 documentation has been updated