Merge pull request #547 from 18F/mgwalker-patch-1

Don't unfurl links in random responses
18F · Sep 9, 2024 · 55f5bea · 55f5bea
2 parents 7856e74 + bda0621
commit 55f5bea
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/scripts/random-responses.js b/src/scripts/random-responses.js
@@ -93,7 +93,7 @@ const responseFrom =
       new RegExp(`(^|\\w)(-?)(\\S+) ${config.trigger}`, "i"),
     ) ?? [false, false, false, false];
 
-    const message = { thread_ts: thread };
+    const message = { thread_ts: thread, unfurl_links: false };
     if (defaultEmoji) {
       message.icon_emoji = defaultEmoji;
     }

diff --git a/src/scripts/random-responses.test.js b/src/scripts/random-responses.test.js
@@ -38,7 +38,11 @@ describe("random responder", () => {
       {
         testName: "simple string response",
         responseList: ["a message"],
-        expected: { text: "a message", thread_ts: "thread timestamp" },
+        expected: {
+          text: "a message",
+          thread_ts: "thread timestamp",
+          unfurl_links: false,
+        },
       },
       {
         testName: "string with emoji",
@@ -47,12 +51,17 @@ describe("random responder", () => {
           text: "b message",
           thread_ts: "thread timestamp",
           icon_emoji: ":emoji:",
+          unfurl_links: false,
         },
       },
       {
         testName: "message object with no name or emoji",
         responseList: [{ text: "c message" }],
-        expected: { text: "c message", thread_ts: "thread timestamp" },
+        expected: {
+          text: "c message",
+          thread_ts: "thread timestamp",
+          unfurl_links: false,
+        },
       },
       {
         testName: "message object with no name",
@@ -61,6 +70,7 @@ describe("random responder", () => {
           text: "d message",
           thread_ts: "thread timestamp",
           icon_emoji: ":emoji:",
+          unfurl_links: false,
         },
       },
       {
@@ -70,6 +80,7 @@ describe("random responder", () => {
           text: "e message",
           thread_ts: "thread timestamp",
           username: "bob",
+          unfurl_links: false,
         },
       },
       {
@@ -80,6 +91,7 @@ describe("random responder", () => {
           thread_ts: "thread timestamp",
           icon_emoji: ":emoji:",
           username: "bob",
+          unfurl_links: false,
         },
       },
     ];