[FEATURE] PixTable sur Pix Admin épisode 6 (PIX-16988). #11626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiaPena
added
👀 Tech Review Needed
👀 Func Review Needed
AndreiaPena
force-pushed
the
pix-16988-table-on-last-certification-tables-on-pix-admin
branch
from
b921926 to
948f15f
Compare
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
Jeyffrey
approved these changes
Mar 12, 2025
| </div> | ||
| </div> | ||
| <PixTable | ||
| class="certification-details-v3-table" |
There was a problem hiding this comment.
class="certification-details-v3__table"
| /> | ||
| {{/if}} | ||
|
|
||
| {{#if (this.shouldDisplayAnswerValueIcon certificationChallenge)}} |
There was a problem hiding this comment.
J'ai du mal à comprendre ce if 🤯
| </table> | ||
| </PixBlock> | ||
| <PixTable | ||
| class="certification-details-v3-table" |
There was a problem hiding this comment.
class="certification-details-v3__table"
| </tbody> | ||
| </table> | ||
| <PixTable | ||
| class="certification-details-v3-table" |
There was a problem hiding this comment.
class="certification-details-v3__table"
Comment on lines
42
to
+45
| assert.ok(true); | ||
| sinon.assert.calledWith( | ||
| notificationSuccessStub, | ||
| t('components.administration.organizations-import.notifications.success'), | ||
| ); | ||
| sinon.assert.calledWith(notificationSuccessStub, { | ||
| message: t('components.administration.organizations-import.notifications.success'), | ||
| }); |
There was a problem hiding this comment.
Suggested change
| assert.ok(true); | |
| sinon.assert.calledWith( | |
| notificationSuccessStub, | |
| t('components.administration.organizations-import.notifications.success'), | |
| ); | |
| sinon.assert.calledWith(notificationSuccessStub, { | |
| message: t('components.administration.organizations-import.notifications.success'), | |
| }); | |
| assert.true(notificationSuccessStub.calledWith({ | |
| message: t('components.administration.organizations-import.notifications.success'), | |
| })); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
Le composant PixTable existe mais n'est pas du tout utilisé dans nos applications
🥓 Proposition
Continuer les tableaux coté pages de la team Certif.
🧃 Remarques
Manque les tableaux des centres de certif, et j'aurais fini les tableaux certification 🥳
😋 Pour tester
Les tableaux à checker sur Pix Admin :