[TECH] Suppression du feature toggle FT_PIX1D_ENABLED #11624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurelie-crouillebois
added
👀 Tech Review Needed
Func Review OK
aurelie-crouillebois
added
the
feature-toggle
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
aurelie-crouillebois
added
👀 Func Review Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
Un feature toggle avait été mis en place durant le développement de Pix Junior pour n'ouvrir l'accès aux routes destinées à Pix Junior que sur des plateformes internes.
Avec l'ouverture du service, ce feature toggle n'a plus d'intérêt.
🥓 Proposition
Le supprimer ainsi que tout le code s'y référant (security pre handler entre autres).
😋 Pour tester
Supprimer la variable d'environnement FT_PIX_1D_ENABLED de la review app et redémarrer.
Après redémarrage, l'application Pix Junior est toujours fonctionnelle : il est possible d'accéder à une école et de passer une mission.