F-Droid can't build

[licaon-kter]

...since we build reanimated first and we hit this issue: facebook/react-native#35210

I've hacked around it by bumping react-native to 0.67.5: https://gitlab.com/fdroid/fdroiddata/-/commit/4a750ce2145dd4773092ed3ac551e59d47dccdb3 (based on https://github.com/laurent22/joplin/pull/7307/files)

Can you do this update project wide instead?

[gnprice]

Reasonable to take that upgrade. Want to send a PR?

To be explicit here, this is something that's caused by some of the munging that that F-Droid script does with our build. Out of the box our build works fine, after we fixed that issue the day it happened: 117e548 / #5535

[licaon-kter]

I could.

What I don't know is, where is this hash coming from at the end of .tgz: https://github.com/zulip/zulip-mobile/blob/main/yarn.lock#L13512 ?

[licaon-kter]

Google Services sneaked in :(
ref: 0f6cf39

ref: https://web.archive.org/web/20230220124336/https://monitor.f-droid.org/builds/log/com.zulipmobile/201

/LE: disabled https://gitlab.com/fdroid/fdroiddata/-/commit/f40975528828f729a02ce428986c9333451d11fb

[gnprice]

Google Services sneaked in :(
ref: 0f6cf39

Nothing snuck in. We've been quite clear all along that we use Google Play Services for getting notifications. This is part of that.

What happened is that the way you chose to make an F-Droid build involves some sed scripts that depend on the exact details of our source code. We never promised that those details would stay the same. In fact, I specifically warned you that they would probably change, and that your approach was likely to break: #1270 (comment)

Just to make sure we have a shared set of expectations: there's a lot of stuff in that prebuild recipe that we can't guarantee will keep working. It's entirely likely that some of that recipe will break in the future.

If you have specific questions, we can try to help. But this isn't the right tracker for a build failure in the F-Droid script, so I'm closing this issue for now. If you have a specific question to ask, just reply (or feel free to open a new issue) and I can reopen.

[licaon-kter]

I guess I forgot what the workflow is for this app. My bad.

[eighthave]

How about making an fdroid build flavor? That works well for lots of other apps in a similar boat.

[gnprice]

How about making an fdroid build flavor? That works well for lots of other apps in a similar boat.

Sure, we'd be open to a PR for that. Here's previous discussion of what it would look like:
#1270 (comment)