Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New private message/group does not appear after making a new message group #3460

Closed
ghost opened this issue Apr 23, 2019 · 4 comments
Closed
Labels
duplicate Task closed to consolidate with an equivalent task.

Comments

@ghost
Copy link

ghost commented Apr 23, 2019

iOS 12.1 & 12.2
Zulip 23.2.111

Clicking "Create Group" allows me to compose a new private message for someone, but when I go back to the PM screen, that group or recipient does not show up in the list. The only way to get to it is from the "All Messages" screen, or by force quitting and relaunching the app.

This bug has a decently high impact on our workflows

@ghost
Copy link
Author

ghost commented Apr 23, 2019

Sounds like this has the potentially to get automatically fixed when support for #3133 hits.

@m4tf3r
Copy link

m4tf3r commented May 2, 2019

After looking at server code, I fixed this by setting in constants.js:
export const LAST_MESSAGE_ANCHOR = 1e16;
From what I understood, for message events to work as intended, the server must get exactly this number as message anchor (the number is set in zerver/views/messages.py, line 64).

@chrisbobbe
Copy link
Contributor

Thanks for the report and investigation! As it happens, it looks like we’re very near to resolving this in #3654 (comment). Please let me know if I’ve closed this in error; pinging @gnprice to double-check.

@gnprice
Copy link
Member

gnprice commented Feb 11, 2020

I just attempted to repro this at the current version from master (d7b68bd, coming after #3654 was merged), and it indeed appears to be fixed!

One key element of this bug description is that this is about a case where you've actually sent a message to that new group of people. If you do "Create Group", and look at the message-list screen for that group, but don't actually send (or receive) a message there, then when you go back to the PM conversations screen you still won't see the group there. That other behavior isn't exactly a bug -- it's a natural consequence of the Zulip way of thinking about PM conversations, and the webapp has the exact same behavior, though it might well be surprising.

In any case that behavior is pretty independent of this issue, so if we wanted to discuss changing it that should be a new issue. Mentioning it here in case someone comes looking for an issue about that behavior and finds this one 🙂

@gnprice gnprice added the duplicate Task closed to consolidate with an equivalent task. label Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Task closed to consolidate with an equivalent task.
Projects
None yet
Development

No branches or pull requests

3 participants