Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible/how to implement folding with the closing bracket on the same line? #12

Closed
YakovL opened this issue Jan 21, 2020 · 4 comments

Comments

@YakovL
Copy link

YakovL commented Jan 21, 2020

There's a long-living thread in the VS Code repo, is vscode-explicit-folding capable of implementing this? If it is, is there a settings snippet to apply and go? If not, can this be implemented, what does this require? Since a number of devs are interested, this may deserve some attention

@daiyam
Copy link
Member

daiyam commented Jan 21, 2020

Hi Yakov, this extension won't fix the referenced issue.
I'm avoiding the issue with a custom build with the PR microsoft/vscode#54200 that I've made. (So the foldings can only be provided only by this extension)

@daiyam
Copy link
Member

daiyam commented Mar 22, 2020

Hi Yakov, I'm not sure if it's useful to you but I've made my custom version of VSCode available at https://github.com/zokugun/MrCode.
Also, for the explicit extension, I've added the foldLastLine property to include or not the last line into the folding.

@hoppfrosch
Copy link

Just to be sure: Using this extension you need to use your customised version of VSCode? Or does your extension work with plain VSCode as well (with restricted features?)?

@daiyam
Copy link
Member

daiyam commented Mar 23, 2020

Hi @hoppfrosch , this extension works with VSCode but the default foldings (provided by auto or indentation) will always be present. My customized version avoids this if you set the editor.foldingStrategy to explicit.

@daiyam daiyam closed this as completed May 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants