You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now evm-bench just expects an executable that implements the runner interface. So I guess the executable could call docker and do this. But runners typically just go raw.
I imagine an improvement would be to use mandatory Dockerfiles that can be built and run with an entry point that satisfies the runner interface. The metadata file for runners could point to that Dockerfile.
Some benefits:
More standardized environment. For example, it becomes a lot easier to make sure the same Python version is running benchmarks.
Less dependency management. No need to have poetry or go or whatever toolchain installed to build runners anymore!
Do we need to care about performance? I don't think this is that big of a deal since things are mostly meant to be taken relatively anyway. So as long as we're consistent, we're good.
The text was updated successfully, but these errors were encountered:
ziyadedher
changed the title
Implement runner entries via Dockerfiles
Implement runner via Dockerfiles
Oct 14, 2022
ziyadedher
changed the title
Implement runner via Dockerfiles
Implement runners via Dockerfiles
Oct 14, 2022
Right now evm-bench just expects an executable that implements the runner interface. So I guess the executable could call docker and do this. But runners typically just go raw.
I imagine an improvement would be to use mandatory Dockerfiles that can be built and run with an entry point that satisfies the runner interface. The metadata file for runners could point to that Dockerfile.
Some benefits:
poetry
orgo
or whatever toolchain installed to build runners anymore!Do we need to care about performance? I don't think this is that big of a deal since things are mostly meant to be taken relatively anyway. So as long as we're consistent, we're good.
The text was updated successfully, but these errors were encountered: