Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement runners via Dockerfiles #21

Open
ziyadedher opened this issue Oct 14, 2022 · 0 comments
Open

Implement runners via Dockerfiles #21

ziyadedher opened this issue Oct 14, 2022 · 0 comments

Comments

@ziyadedher
Copy link
Owner

Right now evm-bench just expects an executable that implements the runner interface. So I guess the executable could call docker and do this. But runners typically just go raw.

I imagine an improvement would be to use mandatory Dockerfiles that can be built and run with an entry point that satisfies the runner interface. The metadata file for runners could point to that Dockerfile.

Some benefits:

  • More standardized environment. For example, it becomes a lot easier to make sure the same Python version is running benchmarks.
  • Less dependency management. No need to have poetry or go or whatever toolchain installed to build runners anymore!

Do we need to care about performance? I don't think this is that big of a deal since things are mostly meant to be taken relatively anyway. So as long as we're consistent, we're good.

@ziyadedher ziyadedher changed the title Implement runner entries via Dockerfiles Implement runner via Dockerfiles Oct 14, 2022
@ziyadedher ziyadedher changed the title Implement runner via Dockerfiles Implement runners via Dockerfiles Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant