Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for react 19 #321

Open
captain-igloo opened this issue Dec 17, 2024 · 4 comments
Open

Add support for react 19 #321

captain-igloo opened this issue Dec 17, 2024 · 4 comments

Comments

@captain-igloo
Copy link

react 19 is not supported

@vladboss61
Copy link

vladboss61 commented Dec 17, 2024

react 19 is not supported

Yes, I have got problems after migration to React 19 too.

There were errors during the build, and some troubles with ReactSlider component.

 Its type 'typeof ReactSlider' is not a valid JSX element type.
  Type 'typeof ReactSlider' is not assignable to type 'new (props: any) => Component<any, any, any>'. 
    Construct signature return types 'ReactSlider<any>' and 'Component<any, any, any>' are incompatible.
      The types returned by 'render()' are incompatible between these types.
         Type 'ReactElement<any, string | JSXElementConstructor<any>>' is not assignable to type 'ReactNode'.
              Property 'children' is missing in type 'ReactElement<any, string | JSXElementConstructor<any>>' but required in type 'ReactPortal'.

Please fix its :)

@Karmalakas
Copy link

I guess it's related:

react-jsx-runtime.development.js?bb19:87 Warning: A props object containing a "key" prop is being spread into JSX
... /node_modules/react-slider/dist/es/dev/components/ReactSlider/ReactSlider.mjs:123:30

I get this on React v18.3, which is to make migration to v19 easier. It shows all the deprecated stuff, but still works

Basically it says, instead of:

const props = {
  key: id,
  className: "my-class",
}

return <Component {...props} />

Needs to be:

const props = {
  className: "my-class",
}

return <Component key={id} {...props} />

@GenGraphic
Copy link

I need also support for react 19

@m10
Copy link

m10 commented Jan 21, 2025

I am not sure this project is maintained anymore. Nothing happened for 2 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants