Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 3.22.0 double compute issue in version 14.x #30

Closed
robclancy opened this issue Nov 3, 2020 · 2 comments
Closed

Ember 3.22.0 double compute issue in version 14.x #30

robclancy opened this issue Nov 3, 2020 · 2 comments

Comments

@robclancy
Copy link

robclancy commented Nov 3, 2020

You can reproduce with your own tests. Just checkout version 14 and run tests.

Uncaught Error: Assertion Failed: You attempted to update `tabIndex` on `SelectBox`, but it had already been used previously in the same computation.  Attempting to update a value after using it in a computation can cause logical errors, infinite revalidation bugs, and performance issues, and is not supported.

`tabIndex` was first used:

Stack trace for the update:
    at setter (validator.js:833)
    at SelectBox.set [as tabIndex] (index.js:3908)
    at enable (disabled.js:23)
    at receiveDisabled (disabled.js:13)
    at new SelectBox (index.js:199)
@robclancy robclancy changed the title Ember 3.22.0 double compute issue Ember 3.22.0 double compute issue in version 14.x Nov 3, 2020
@amk221
Copy link
Contributor

amk221 commented Dec 13, 2020

I checked out the 14x tag and updated to Ember 3.22.0. It does output a load of:

DEPRECATION: You attempted to update `tabIndex` on `SelectBox`, but it had already been used previously in the same computation.  Attempting to update a value after using it in a computation can cause logical errors, infinite revalidation bugs, and performance issues, and is not supported.

`tabIndex` was first used:

- While rendering:
  application
    index
      select-box

...but all the tests pass.

Do you have any more details for how to make it error, like your example

@robclancy
Copy link
Author

robclancy commented Dec 22, 2020

That's because they changed it in 3.22.2 and you must have tested that version.
emberjs/ember.js#19282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants