Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileMutex and other cases #1

Closed
machour opened this issue Jan 13, 2019 · 1 comment
Closed

Fix FileMutex and other cases #1

machour opened this issue Jan 13, 2019 · 1 comment

Comments

@machour
Copy link
Member

machour commented Jan 13, 2019

I believe we should do a global code review on this repo.

For example, in https://github.com/yiisoft/mutex/blob/master/src/FileMutex.php#L66 isWindows never gets a chance to be anything other than null. Probably a mistake while migrating from init().

Tests didn't pick that up, so we also need to increase coverage.

@samdark
Copy link
Member

samdark commented Jan 14, 2019

Ideally that should be done for every package...

@samdark samdark transferred this issue from yiisoft/mutex Apr 14, 2019
@samdark samdark pinned this issue Sep 16, 2019
@samdark samdark closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants