We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I believe we should do a global code review on this repo.
For example, in https://github.com/yiisoft/mutex/blob/master/src/FileMutex.php#L66 isWindows never gets a chance to be anything other than null. Probably a mistake while migrating from init().
isWindows
null
Tests didn't pick that up, so we also need to increase coverage.
The text was updated successfully, but these errors were encountered:
Ideally that should be done for every package...
Sorry, something went wrong.
No branches or pull requests
I believe we should do a global code review on this repo.
For example, in https://github.com/yiisoft/mutex/blob/master/src/FileMutex.php#L66
isWindows
never gets a chance to be anything other thannull
. Probably a mistake while migrating from init().Tests didn't pick that up, so we also need to increase coverage.
The text was updated successfully, but these errors were encountered: