Skip to content

Commit ff211e3

Browse files
committed
review + post merge fixes
1 parent 9370df3 commit ff211e3

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

packages/yew-agent/src/worker/mod.rs

+6-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ pub use public::Public;
88
use super::*;
99
use js_sys::{Array, Reflect, Uint8Array};
1010
use serde::{Deserialize, Serialize};
11-
use wasm_bindgen::{closure::Closure, JsCast, JsValue};
11+
use wasm_bindgen::{closure::Closure, JsCast, JsValue, UnwrapThrowExt};
1212
use web_sys::{
1313
Blob, BlobPropertyBag, DedicatedWorkerGlobalScope, MessageEvent, Url, Worker, WorkerOptions,
1414
};
@@ -71,7 +71,11 @@ where
7171
}
7272

7373
fn worker_new(name_of_resource: &str, is_module: bool) -> Worker {
74-
let origin = gloo_utils::document().location().unwrap().origin().unwrap();
74+
let origin = gloo_utils::document()
75+
.location()
76+
.unwrap_throw()
77+
.origin()
78+
.unwrap_throw();
7579
let script_url = format!("{}/{}", origin, name_of_resource);
7680
let wasm_url = format!("{}/{}", origin, name_of_resource.replace(".js", "_bg.wasm"));
7781
let array = Array::new();

packages/yew-router/src/history.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ use std::cell::RefCell;
55
use std::rc::{Rc, Weak};
66

77
use gloo::events::EventListener;
8+
use gloo_utils::window;
89
use serde::de::DeserializeOwned;
910
use serde::Serialize;
1011
use thiserror::Error;
1112
use wasm_bindgen::{JsValue, UnwrapThrowExt};
1213
use yew::callback::Callback;
13-
use yew::utils::window;
1414

1515
use crate::utils::base_url;
1616
use crate::Routable;

packages/yew-router/src/utils.rs

-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ pub fn fetch_base_url() -> Option<String> {
4545
mod tests {
4646
use gloo_utils::document;
4747
use wasm_bindgen_test::wasm_bindgen_test as test;
48-
use yew::utils::*;
4948
use yew_router::prelude::*;
5049
use yew_router::utils::*;
5150

packages/yew/tests/use_reducer.rs

+6-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
use std::collections::HashSet;
22
use std::rc::Rc;
33

4+
use gloo_utils::document;
45
use wasm_bindgen::JsCast;
56
use wasm_bindgen_test::*;
67
use web_sys::HtmlElement;
@@ -116,13 +117,13 @@ fn use_reducer_eq_works() {
116117
}
117118
type UseReducerComponent = FunctionComponent<UseReducerFunction>;
118119
yew::start_app_in_element::<UseReducerComponent>(
119-
yew::utils::document().get_element_by_id("output").unwrap(),
120+
document().get_element_by_id("output").unwrap(),
120121
);
121122

122123
let result = obtain_result();
123124
assert_eq!(result.as_str(), "1");
124125

125-
yew::utils::document()
126+
document()
126127
.get_element_by_id("add-a")
127128
.unwrap()
128129
.unchecked_into::<HtmlElement>()
@@ -131,7 +132,7 @@ fn use_reducer_eq_works() {
131132
let result = obtain_result();
132133
assert_eq!(result.as_str(), "2");
133134

134-
yew::utils::document()
135+
document()
135136
.get_element_by_id("add-a")
136137
.unwrap()
137138
.unchecked_into::<HtmlElement>()
@@ -140,7 +141,7 @@ fn use_reducer_eq_works() {
140141
let result = obtain_result();
141142
assert_eq!(result.as_str(), "2");
142143

143-
yew::utils::document()
144+
document()
144145
.get_element_by_id("add-b")
145146
.unwrap()
146147
.unchecked_into::<HtmlElement>()
@@ -149,7 +150,7 @@ fn use_reducer_eq_works() {
149150
let result = obtain_result();
150151
assert_eq!(result.as_str(), "3");
151152

152-
yew::utils::document()
153+
document()
153154
.get_element_by_id("add-b")
154155
.unwrap()
155156
.unchecked_into::<HtmlElement>()

0 commit comments

Comments
 (0)