Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Commit 35d7d5f

Browse files
CountryenPascal RiedbijingtonpictosTheCodeTraveler
authoredDec 3, 2021
Bugfix Issue #1705 (MAUI: 184): Allow null handling for BaseConverterOneWay<TFrom, TTo> (#1733)
* Fix typo ArgumenException for unit tests * Add AllowsNullOrDefault handling for BaseConverterOneWay Fix summary xml doc for ConvertBack of BaseConverterOneWay * Add BaseConverterOneWay_Tests for new AllowsNullOrDefault * Implement recommended changes - Rename test converter to MockConverterOneWay - Change ArgumentException to ArgumentNullException in BaseConverterOneWay<TFrom, TTo> when disallowing nulls - Simplify unit test data generation and execution * Update null check in BaseConverterOneWay<TFrom, TTo> * Implement recommended changes - Change check order back to original in BaseConverterOneWay<TFrom, TTo> - Fix missing first paramName argument for ArgumentNullException in BaseConverterOneWay<TFrom, TTo> - Refactor BaseConverterOneWay_Tests * Rename property AllowsNullOrDefault to AllowsNull of BaseConverterOneWay<TFrom, TTo> * Update IsNullOrEmptyConverter to inherit from BaseConverterOneWay<TFrom, TTo> * Migrated more converters to base * Revert compare converter changes * Fixed unit tests and code review tidy up * Switch to separate nullable converter base class * Add null support to BaseConverter NullableBaseConverter now completes symmetry with NullableBaseConverterOneWay. Migrate converters to use NullableBaseConverter where possible. Migrate tests to new approach. * Remove Null-Forgiving Operator * Rename converters to start with Base * Code review improvement * Add global.json Ensures .NET 6.0 is the minimum version in use * `dotnet format` * Move global.json to root folder * `dotnet format` Co-authored-by: Pascal Ried <[email protected]> Co-authored-by: Shaun Lawrence <[email protected]> Co-authored-by: Pedro Jesus <[email protected]> Co-authored-by: Brandon Minnick <[email protected]>
1 parent cbf4a19 commit 35d7d5f

File tree

116 files changed

+575
-598
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

116 files changed

+575
-598
lines changed
 

‎Directory.Build.props

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33

44
<PropertyGroup Condition="'$(MSBuildProjectExtension)' == '.csproj'">
5-
<LangVersion>9.0</LangVersion>
5+
<LangVersion>latest</LangVersion>
66
<Nullable>enable</Nullable>
77
<WarningsAsErrors>nullable</WarningsAsErrors>
88
</PropertyGroup>

‎global.json

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"sdk": {
3+
"version": "6.0.*",
4+
"rollForward": "latestMajor"
5+
}
6+
}

0 commit comments

Comments
 (0)
This repository has been archived.