You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a RwLockWriteGuard. This should not be Send if send_guard is not enabled.
Maybe we should add a feature gate over the unsafe impl of Send and Sync for OccupiedEntry?
Thanks for investigating into this in advance!
The text was updated successfully, but these errors were encountered:
skyzh
changed the title
when send_guard is disabled, Entry operations might be unsafe?
when send_guard is disabled, Entry should not be Send?
Mar 22, 2022
For any circumstances, we always unsafe impl Send and Sync for Entry:
dashmap/src/mapref/entry.rs
Lines 139 to 144 in afe293f
But within
OccupiedEntry
:dashmap/src/mapref/entry.rs
Lines 133 to 137 in afe293f
We have a
RwLockWriteGuard
. This should not beSend
ifsend_guard
is not enabled.Maybe we should add a feature gate over the unsafe impl of Send and Sync for
OccupiedEntry
?Thanks for investigating into this in advance!
The text was updated successfully, but these errors were encountered: