Redirect to 404 when fetching src files on dev server

[rotate-mark]

Astro Info

Astro                    v5.2.0
Node                     v18.20.3
System                   Linux (x64)
Package Manager          npm
Output                   server
Adapter                  @astrojs/node
Integrations             @astrojs/alpinejs

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

The dev server redirects the src files request and causes a vite internal server error after upgrading to Astro v5.2.0.

// Without the trailingSlash config, src file requests redirect to 404.

// When trailingSlash is set to 'always', requests to @vite/client return 404.

What's the expected result?

Return 200 and it would not break the page on dev server.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-4nxjmnm3?file=astro.config.mjs

Participation

• I am willing to submit a pull request for this issue.

[druettiger]

I can reproduce the issue in Astro 5.2.0:

1. Create a new Astro project
2. Set trailingSlash: 'always'
3. Run npm run dev

Result:

• Site preview not updating on file changes
• Astro dev toolbar not loading

[ascorbic]

Thanks. I have a fix #13095

[rotate-mark]

@ascorbic Thanks for the quick fix. However, the issue still exists as the srcDir files goes with double slashes path.

The collapseDuplicateTrailingSlashes function should exclude those paths as well.

// @astrojs/internal-helpers/path.js

function collapseDuplicateTrailingSlashes(path, trailingSlash) {
  if (!path) {
    return path;
  }

  if (path.startsWith('/@') || path.startsWith('/_')) {
    return path;
  }

  return path.replace(MANY_TRAILING_SLASHES, trailingSlash ? "/" : "") || "/";
}