-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most components are mounted out of context in the React devtools #16
Comments
This occurs whenever a ReactWinJS component calls There are a couple of things to investigate for fixing this:
ReactWinJS components call Thanks for the report. |
@rigdern I wrote a smaller binding for winjs with react before we switched to this, init i used to render the winjs components Can that approach not be used ? |
@darkyen I believe we are using the approach you described: The problem occurs when a WinJS control hosts HTML content and you want to describe that content as a React component. For example, how would you implement the SplitView component such that you can describe the pane as a React component? Our current implementation will construct the SplitView using the method you described. However, it'll call |
oh okay, i understand the exact cause now. #Hacky way i made it work (for a completely different reason) |
The above is a screenshot when React Inspector was used in chrome devtools, I'd expect the above to look like
I wonder why most things are uprooted and rendered on top level instead of the react way ?
The text was updated successfully, but these errors were encountered: