Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new GitHub README template. #39

Open
ghost opened this issue Mar 17, 2012 · 7 comments
Open

Add support for the new GitHub README template. #39

ghost opened this issue Mar 17, 2012 · 7 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Mar 17, 2012

I'd love the new GitHub README template to be available as the new default.
The current default could be renamed github_old.

@wikimatze
Copy link
Owner

Yeah, I'm working on it, and will release it at the end of the week.

@ghost ghost assigned wikimatze Mar 18, 2012
@wikimatze
Copy link
Owner

It's done - see commit 078cb11

@ghost
Copy link
Author

ghost commented Mar 19, 2012

Thanks! I think it might need to be tweaked, though, because the font is not the same and the padding on <li> elements seems to be different as well. I think it could be cool if we wrapped the README in the same UI element that GItHub is using. Thoughts?

@ghost ghost reopened this Mar 19, 2012
@wikimatze
Copy link
Owner

See commits b67eed8...eb1cec1 - in my eyes it should fit now.

@wikimatze
Copy link
Owner

Is the layout okay for now or should I ask the github people for their layout?

@ghost
Copy link
Author

ghost commented Apr 26, 2012

I think the layout is closer but not close enough. The original README template(old github theme) was almost identical, and I'd like the new template to have the same level of similarity. I don't think we need to ask GitHub for their markup, I think the layout can be easily matched (we're aiming for 95%+ similarity, not 100%). After that, we just need to apply similar CSS rules to make sure everything matches.

I see the old github theme is totally gone as well, I think we should keep it around, maybe as github-legacy.

@wikimatze
Copy link
Owner

github-legacy is a good idea - I will restore it this evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant