fix: make types for modify route config more accurate

Author: wheresrhys

packages/fetch-mock/src/FetchMock.ts

@@ -3,7 +3,7 @@ import Route, {
 	RouteName,
 	UserRouteConfig,
 	RouteResponse,
-	NullableUserRouteConfig,
+	ModifyRouteConfig,
 } from './Route.js';
 import { MatcherDefinition, RouteMatcher } from './Matchers.js';
 import CallHistory from './CallHistory.js';
@@ -148,7 +148,7 @@ export class FetchMock {
 		return this;
 	}
 
-	modifyRoute(routeName: string, options: NullableUserRouteConfig) {
+	modifyRoute(routeName: string, options: ModifyRouteConfig) {
 		this.router.modifyRoute(routeName, options);
 		return this;
 	}

packages/fetch-mock/src/Route.ts

@@ -39,7 +39,10 @@ export type InternalRouteConfig = {
 };
 export type UserRouteConfig = UserRouteSpecificConfig & FetchMockGlobalConfig;
 type Nullable<T> = { [K in keyof T]: T[K] | null };
-export type NullableUserRouteConfig = Nullable<UserRouteConfig>;
+export type ModifyRouteConfig = Omit<
+	Nullable<UserRouteSpecificConfig>,
+	'name' | 'sticky'
+>;
 
 export type RouteConfig = UserRouteConfig &
 	FetchImplementations &
@@ -124,7 +127,7 @@ class Route {
 		this.init(config);
 	}
 
-	init(config: RouteConfig | NullableUserRouteConfig) {
+	init(config: RouteConfig | ModifyRouteConfig) {
 		this.config = config;
 		this.#sanitize();
 		this.#validate();

packages/fetch-mock/src/Router.ts

@@ -6,7 +6,7 @@ import Route, {
 	RouteResponse,
 	RouteResponseData,
 	RouteResponseConfig,
-	NullableUserRouteConfig,
+	ModifyRouteConfig,
 } from './Route.js';
 import { isUrlMatcher, isFunctionMatcher } from './Matchers.js';
 import { RouteMatcher } from './Matchers.js';
@@ -385,7 +385,7 @@ export default class Router {
 		}
 	}
 
-	modifyRoute(routeName: string, options: NullableUserRouteConfig) {
+	modifyRoute(routeName: string, options: ModifyRouteConfig) {
 		const route = this.routes.find(
 			({ config: { name } }) => name === routeName,
 		);
@@ -400,7 +400,7 @@ export default class Router {
 			);
 		}
 
-		if (options.name) {
+		if ('name' in options) {
 			throw new Error(
 				`Cannot rename the route \`${routeName}\` as \`${options.name}\`: renaming routes is not supported`,
 			);

packages/fetch-mock/src/index.ts

@@ -5,7 +5,7 @@ export {
 } from './FetchMock.js';
 export { CallHistoryFilter, CallLog } from './CallHistory.js';
 export { RouteMatcher, MatcherDefinition } from './Matchers.js';
-export { UserRouteConfig, RouteResponse, RouteName } from './Route.js';
+export { UserRouteConfig, RouteResponse, RouteName, ModifyRouteConfig } from './Route.js';
 export { RemoveRouteOptions } from './Router.js';
 
 import fetchMock from './FetchMock.js';