Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 79cb3ca

Browse files
emiliomoz-wptsync-bot
authored andcommittedJun 12, 2023
Fix media query tests.
As per https://drafts.csswg.org/css-values-4/#resolution-value negative resolutions are always invalid, even in media queries. Differential Revision: https://phabricator.services.mozilla.com/D180352 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1836564 gecko-commit: c5dec1d6323fdaedf50204c26ff3ead8153417f8 gecko-reviewers: dholbert
1 parent 4d6a27d commit 79cb3ca

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed
 

‎css/mediaqueries/mq-negative-range-001.html

-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
and
1919
(min-height: -100px)
2020
and
21-
(min-resolution: -1dpi)
22-
and
2321
(min-color: -10)
2422
and
2523
(min-color-index: -10)

‎css/mediaqueries/mq-negative-range-002.html

-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
and
1919
(not (max-height: -100px))
2020
and
21-
(not (max-resolution: -1dpi))
22-
and
2321
(not (max-color: -10))
2422
and
2523
(not (max-color-index: -10))

‎css/mediaqueries/test_media_queries.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -463,10 +463,10 @@
463463
expression_should_be_known(feature + ": 1.5x");
464464
expression_should_be_known(feature + ": 2.0dppx");
465465
expression_should_be_known(feature + ": 0dpi");
466-
expression_should_be_known(feature + ": -3dpi");
467466
expression_should_be_known(feature + ": 0dppx");
468467
expression_should_be_known(feature + ": 0x");
469468
expression_should_be_known(feature + ": calc(6x / 2)");
469+
expression_should_be_unknown(feature + ": -3dpi");
470470
}
471471

472472
// Find the resolution using max-resolution

0 commit comments

Comments
 (0)
Please sign in to comment.