Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What makes this better than gulp-wrap-* modules? #3

Closed
phated opened this issue Mar 13, 2014 · 1 comment
Closed

What makes this better than gulp-wrap-* modules? #3

phated opened this issue Mar 13, 2014 · 1 comment

Comments

@phated
Copy link

phated commented Mar 13, 2014

I noticed you are commenting on a lot of plugins that are blacklisted due to complexity with a PR to remove their special wrapping and adding your module to their docs. What makes this better than https://github.com/phated/gulp-wrap-umd and https://github.com/phated/gulp-wrap-amd among other wrapping modules.

This module seems to do many things, which is typically an anti-pattern for gulp plugins. I am just trying to understand why we need more wrapping modules.

Thanks.

@wbyoung
Copy link
Owner

wbyoung commented Mar 13, 2014

We don't. I'm new to gulp.js trying to navigate the vast number of plugins. I was unaware of those when I started trying to make gulp work with Emblem and Ember. This was created as an abstraction from everything going on in the gulp-handlebars fork mess. It's really an attempt to try to reduce the shared logic and complexity from those plugins.

I'll happily remove it if we can figure out how to make gulp-handlebars simple yet handle the permutations of Handlebars/Ember.Handlebars/Emblem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants