Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 5 #15

Open
hlascelles opened this issue Feb 9, 2018 · 5 comments
Open

Rails 5 #15

hlascelles opened this issue Feb 9, 2018 · 5 comments

Comments

@hlascelles
Copy link
Contributor

It feels like only 4 years have gone by since I was last here.

Are there any plans to release a Rails 5 compatible version? I see there are forks which have it running.

@simeonwillbanks, does it work for you? Would you create a PR?
@rx
Copy link
Collaborator

rx commented Feb 9, 2018

Welcome back!

I'd be happy to do a release for a Rails 5 PR. If you (or someone) can issue a PR with the suggested changes. I'll manage the release.

@hlascelles
Copy link
Contributor Author

Great, thanks! We are still upgrading, so haven't tested a PR worthy branch yet. If someone else has one, go for it, otherwise we'll be along eventually.

@hlascelles
Copy link
Contributor Author

NB, we are still planning on this, just upgrading all the things.

@hlascelles
Copy link
Contributor Author

PR created! #17 I'll close this.

@hlascelles
Copy link
Contributor Author

@rx, would you mind if I created a egregious-rails5 gem for now? Or if there is something I can change on the PR, I can do that?

@hlascelles hlascelles reopened this Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rx @hlascelles