Accept/Reject - Grouping changeing

[PraveenAsh]

The hunks for the [Accept] and [Reject] are very dispersed across lines instead of chunks. Grouping them will make it accept/reject fast.

The Problem:
IMAGE Linked below
The UX is bad as the number of clicks to get this one function accepted is 4 Clicks. that's expensive!

Possible Solution:
Without either LCS (Longest Contiguous Sequence) or just grouping anything with a buffer range ie squash the hunks into one based on distance from each other.

[mathewpareles]

Thanks for pointing this out!

Does the current version you're using have Accept All and Reject All buttons? This should allow you to do a single click to accept the changes.

We could merge nearby hunks as you suggested. I'm not convinced this would improve the UX. In the above screenshot, we'd either end up merging all the diffs together which doesn't seem ideal (using a merging distance of 2), or we'd only eliminate one of the diffs (using a merging distance of 1).

[PraveenAsh]

Yeah, this is with Accept All and Reject All, but the UX is broken.

Most edits are function/class/method-specific. Look at the picture—handleGoogleSignIn got changed, and applying does 4 edits. Now imagine a failed Apply on another function(with 4 clicks) in the same file.

Right now, Accept All takes 8 clicks instead of 1. And if a user wants to accept the first function and reject the second? That’s 4 accepts + 4 rejects instead of just 2 clicks. Bad UX.

[mathewpareles]

Can you try reinstalling Void? Sounds like you're on an earlier version.

[PraveenAsh]

Just updated. I see no difference. Although, this kinda makes sense for imports, but definitely not for code blocks.