Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts for Accept/Reject #257

Open
andrewpareles opened this issue Jan 30, 2025 · 2 comments
Open

Keyboard shortcuts for Accept/Reject #257

andrewpareles opened this issue Jan 30, 2025 · 2 comments

Comments

@andrewpareles
Copy link
Contributor

Users should be able to accept and reject a change just using the keyboard, without moving the mouse.

I think the logic should look like this, but open to discussion:

  1. if the user's mouse is on screen, pressing the YES/NO shortcut should accept/reject the closest diff to the mouse.
  2. if the user's mouse is not on screen, pressing YES/NO shortcut should accept/reject the closest diff to the user's selection.

We should indicate which diff a YES/NO shortcut is about to change visually, maybe by only showing Accept|Reject on one diff.

Happy to take suggestions on what the keys should be.

@andrewpareles andrewpareles moved this to 🔎 Improvements (A) in 🚙 Void Roadmap Jan 30, 2025
@DoctorGlitchy
Copy link
Contributor

Ctrl + Enter
Ctrl + Backspace

@andrewpareles
Copy link
Contributor Author

I now think the typical workflow is to accept/reject a few of the changes, and then accept or reject all after that. Sequential keyboard suggestions can interrupt this workflow, so I'm not going to worry about this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Improvements (A)
Development

No branches or pull requests

2 participants