This repository was archived by the owner on Nov 16, 2020. It is now read-only.
CLI: dispatch create seed-images #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used without any arguments, creates base-images and images from images.yaml at the same revision as the CLI build. When used with `-O file.yaml` flag, writes the YAML to the specified file (nothing gets created). Also: - Bump base-image versions - Move images.yaml to the repo root
kars7e
previously approved these changes
Jun 12, 2018
Makefile
Outdated
| GO_LDFLAGS += -X $(VERSION_PACKAGE).buildDate=$(shell date +'%Y-%m-%dT%H:%M:%SZ') | ||
| GO_LDFLAGS += -X $(VERSION_PACKAGE).commit=$(shell git rev-parse HEAD) | ||
| GO_LDFLAGS +=" | ||
|
|
||
| CLI_LDFLAGS := -X $(CLICMD_PACKAGE).imagesB64=$(shell cat images.yaml | gzip | base64) |
There was a problem hiding this comment.
NIT: could be gzip -c images.yaml | base64, one cat's life saved ;)
There was a problem hiding this comment.
No! This would kill the cat! 🙀
kars7e
approved these changes
Jun 12, 2018
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used without any arguments, creates base-images and images from
images.yaml at the same revision as the CLI build. When used with
-O file.yamlflag, writes the YAML to the specified file (nothing getscreated).
Also: