Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: TokenizerGroup doesn't behave like a PreTrainedTokenizer #2713

Closed
saattrupdan opened this issue Feb 1, 2024 · 1 comment
Closed

BUG: TokenizerGroup doesn't behave like a PreTrainedTokenizer #2713

saattrupdan opened this issue Feb 1, 2024 · 1 comment

Comments

@saattrupdan
Copy link

saattrupdan commented Feb 1, 2024

The new TokenizerGroup class that LLM.llm_engine.tokenizer has now become, doesn't behave like a tokenizer.

For instance, the LLM.set_tokenizer method sets the tokenizer attribute as a PreTrainedTokenizer, not a TokenizerGroup.

Also, tools like lm-format-enforcer assumes that the tokenizer attribute is indeed a tokenizer, causing it to now give AttributeErrors.

It seems like either the LLM.llm_engine.tokenizer should revert back to being a PreTrainedTokenizer, or otherwise at least have properties and methods which call the corresponding properties and methods of the underlying PreTrainedTokenizer.

@zhuohan123
Copy link
Member

Should be fixed by #2741.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants