Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): no emit assets in html style tag (fix #5968) #6321

Merged
merged 40 commits into from
Dec 30, 2021

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Dec 30, 2021

Description

fix #5968

Additional context

I think it is better way to resolve inline style.

  • use js import to use css plugin transform inline style. and relace it with a flag, like assets url.
  • css-post plugin record transform result.use result replace flag when generateBundle.

I accidentally deleted repo before. and break link of #6181😭


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

poyoho and others added 30 commits December 9, 2021 12:11
@poyoho
Copy link
Member Author

poyoho commented Dec 30, 2021

Duplicate of #6181

@Niputi Niputi added the p3-minor-bug An edge case that only affects very specific usage (priority) label Dec 30, 2021
@patak-dev patak-dev merged commit dc9fce1 into vitejs:main Dec 30, 2021
@patak-dev
Copy link
Member

@poyoho thanks again for the work you're doing lately in Vite, hats off

@siwa-ddiesenreither
Copy link

Is there a way to disable the replacement of <div style="background-image: url('test.png')"> with <div style="__VITE_INLINE_CSS__..."> - i just want to build my index.html and host it on a server?

@trtrtr6
Copy link

trtrtr6 commented Apr 29, 2022

image

@poyoho

Why exclude underscore here,If there is an underscore on the path, the regularity here cannot match

image

@poyoho
Copy link
Member Author

poyoho commented Apr 30, 2022

Is there a way to disable the replacement of <div style="background-image: url('test.png')"> with <div style="__VITE_INLINE_CSS__..."> - i just want to build my index.html and host it on a server?

hi, maybe not, Can you explain in detail why it is used this way?

@siwa-ddiesenreither
Copy link

siwa-ddiesenreither commented Apr 30, 2022

Is there a way to disable the replacement of <div style="background-image: url('test.png')"> with <div style="__VITE_INLINE_CSS__..."> - i just want to build my index.html and host it on a server?

hi, maybe not, Can you explain in detail why it is used this way?

I am currently using vite as build tool for my Website Design Preview. I've got some .html files like index.html, content.html, contact.html and scss, js etc. So i am developing with vite hot reload and then run vite build and upload the dist folder to a webserver to show my clients the preview. I have got some div's with inline style attributes with background-images so it would be nice if vite just changes to path to the image as it does in scss and does not replace it with an VITE_INLINE_CSS path.

Edit: i am using vite instead of gulp/webpack etc. because it's freakin fast and i like the way to configure it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assets in <style> tags are not processed by vite build
6 participants