Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): no sameCount if clearScreen is false #5648

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

vjee
Copy link
Contributor

@vjee vjee commented Nov 11, 2021

Description

When running the dev server and you're working on a single file, vite will add the amount of times the file was updated at the end of the log like this:

8:49:37 PM [vite] hmr update /src/App.vue (x4)

This is great since the screen is cleared by default.

It does however become useless when clearScreen is set to false.
Somthing like this will be logged:

8:49:29 PM [vite] hmr update /src/App.vue
8:49:31 PM [vite] hmr update /src/App.vue (x2)
8:49:33 PM [vite] hmr update /src/App.vue (x3)
8:49:37 PM [vite] hmr update /src/App.vue (x4)
...

This PR makes it so that the following would be logged instead if clearScreen is false:

8:49:29 PM [vite] hmr update /src/App.vue
8:49:31 PM [vite] hmr update /src/App.vue
8:49:33 PM [vite] hmr update /src/App.vue
8:49:37 PM [vite] hmr update /src/App.vue

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Nov 12, 2021
@patak-dev patak-dev changed the title dx(logger): no sameCount if clearScreen is false fix(logger): no sameCount if clearScreen is false Nov 12, 2021
@patak-dev patak-dev merged commit afd6b6d into vitejs:main Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants