fix: move package.json cache into ResolvedConfig #5388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
added
the
p4-important
bluwy
previously approved these changes
Oct 24, 2021
Shinigami92
reviewed
Oct 24, 2021
aleclarson
force-pushed
the
feat/package-cache
branch
3 times, most recently
from
2542c4e to
fa78284
Compare
…so changes to package.json invalidate the cache. This is useful for linked packages and when a dependency is upgraded. This commit also fixes a bug with `pkg.sideEffects` handling by including `preserveSymlinks` in the cache key.
aleclarson
force-pushed
the
feat/package-cache
branch
from
fa78284 to
0860a43
Compare
Co-authored-by: Shinigami <[email protected]>
Shinigami92
approved these changes
Nov 19, 2021
patak-dev
approved these changes
Nov 19, 2021
antfu
approved these changes
Nov 19, 2021
patak-dev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the (previously global)
package.jsoncache intoResolvedConfig, so the file watcher can do cache invalidation when apackage.jsonfile is changed (which can happen in the case of linked packages).This also fixes an issue with
sideEffectssupport, where the package.json resolutions done withpreserveSymlinks: truewere not disambiguated frompreserveSymlinks: false, leading to false negatives when checkingsideEffectsfor a matched path.What is the purpose of this pull request?