feat: expose searchForWorkspaceRoot util
#4958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
approved these changes
Sep 17, 2021
Shinigami92
added
the
p2-nice-to-have
|
Should we add documentation for this exposed function? |
|
Sorry I don't currently have the bandwidth to write the docs, maybe later in another PR or contribution welcome. |
antfu
added a commit
to antfu/vite
that referenced
this pull request
Sep 23, 2021
patak-dev
pushed a commit
that referenced
this pull request
Sep 24, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When users set
server.fs.strictalong with customserver.fs.allow, the original behavior of searching for workspace root is overwritten. Giving this logic still having some complexity, I think it would be better to expose it for users to reuse the logic.Additional context
In Slidev, we currently vendor the
searchRoot.tsfor that.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).