-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export transformWithEsbuild #4882
feat: export transformWithEsbuild #4882
Conversation
packages/playground/tsconfig-json/__tests__/tsconfig-json.spec.ts
Outdated
Show resolved
Hide resolved
packages/playground/tsconfig-json/__tests__/tsconfig-json.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Dominik G. <[email protected]>
Should the "b" be capitalized? I.e. |
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think we can deprecate server.transformWithEsbuild
with this.
Added deprecation jsdoc for Currently, the vue plugin is still using vite/packages/plugin-vue/src/main.ts Line 261 in e623b4a
|
* feat: export transformWithEsbuild * chore: add tests * fix: test typo Co-authored-by: Dominik G. <[email protected]> * chore: deprecate server.transformWithEsbuild * docs: add transformWithEsbuild Co-authored-by: Dominik G. <[email protected]>
* feat: export transformWithEsbuild * chore: add tests * fix: test typo Co-authored-by: Dominik G. <[email protected]> * chore: deprecate server.transformWithEsbuild * docs: add transformWithEsbuild Co-authored-by: Dominik G. <[email protected]>
* feat: export transformWithEsbuild * chore: add tests * fix: test typo Co-authored-by: Dominik G. <[email protected]> * chore: deprecate server.transformWithEsbuild * docs: add transformWithEsbuild Co-authored-by: Dominik G. <[email protected]>
Description
Expose
transformWithEsbuild
from thevite
package. Also fixestsconfigRaw
merging fortransformWithEsbuild
and perf improvements.Additional context
transformWithEsbuild
is currently already exposed under server, but I don't see it coupled to the server. It could be used as a standalone.vite-plugin-svelte
to use it for preprocessing a Svelte file script tag withlang="ts"
server.transformWithEsbuild
?What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).