-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server): keep port when modifying the config file #4460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when modify the config file
Could you link a bug issue together with a reproduction? |
6 tasks
listen
when modify the config file.listen
when modify the config file. (fix #4464)
listen
when modify the config file. (fix #4464)listen
when modify the config file.
bug description #4464 @Shinigami92 |
6 tasks
Shinigami92
previously approved these changes
Aug 1, 2021
patak-dev
requested changes
Aug 1, 2021
9 tasks
antfu
reviewed
Aug 2, 2021
Shinigami92
reviewed
Aug 2, 2021
Shinigami92
approved these changes
Aug 3, 2021
patak-dev
approved these changes
Aug 3, 2021
listen
when modify the config file.
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I use createServer directly like above, when I modify vite.config.js file, the port is no longer 8000 but the default 3000.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).