-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(css): support css module compose/from path resolution #4378
feat(css): support css module compose/from path resolution #4378
Conversation
Is it possible to add a test case? As you can see, there is also an error you need to fix:
|
ok, I will try to add some test case and fix errors. |
9823e2b
to
66463ff
Compare
a0df1f8
to
e3692f5
Compare
@Shinigami92 I added a |
Thanks for the PR @kamilic. The change looks good to me. About the added test, I think it would be better to add it as an integration test is the css playground. These tests are better for us because we can catch wrong interactions between the diferent pieces. Would you check if it is possible to move it to packages/playground/css? |
I will find time to add some test on playground. |
@patak-js playground tests now added. I think it should be fixed on other pull requests so I commented out some test code and add a @todo tag. |
Great! Thanks for taking the time to add the tests. About the new issue, it would be good to also create a bug report with a that reproduction against the current version so it easier to track it. |
Description
Vite don't support path resolving when using
compose / from
on cssmodule file currently becausepostcss-modules
didn't provide options likedresolve
inpostcss-import
.And now
postcss-modules
supported path resolutiion feature on 4.2.2 so that we can implement / fix this feature.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).