Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow 'hidden' sourcemap to remove //# sourceMappingURL from generated maps #3684

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Conversation

xeoneux
Copy link
Contributor

@xeoneux xeoneux commented Jun 6, 2021

Description

Rollup supports hidden sourcemap where //# sourceMappingURL is not included in the generated sourcemap.

Additional context

This fixes #3683


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jun 6, 2021
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update docs:

vite/docs/config/index.md

Lines 584 to 589 in 6b4c355

### build.sourcemap
- **Type:** `boolean | 'inline'`
- **Default:** `false`
Generate production source maps.

@antfu antfu changed the title Allow 'hidden' sourcemap to remove //# sourceMappingURL from generated maps feat: allow 'hidden' sourcemap to remove //# sourceMappingURL from generated maps Jun 6, 2021
@Shinigami92 Shinigami92 requested review from patak-dev and antfu June 6, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow hidden sourcemap to remove generated comments in sourcemaps
4 participants