Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tolerant fs error in formatError #3665

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

antfu
Copy link
Member

@antfu antfu commented Jun 3, 2021

Description

When plugins failed to process content served by virtual modules, the formatError will try to read the file from fs, which does not exist, causes the real error message being overwritten.

Before:
image

After:
image

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu requested review from patak-dev and Shinigami92 June 3, 2021 12:12
@patak-dev patak-dev merged commit 5146cc5 into vitejs:main Jun 4, 2021
@antfu antfu deleted the fix/format-error-virtual branch June 4, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants