fix: update esbuild to 0.12 #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
requested review from
Shinigami92,
nihalgonsalves,
anncwb and
patak-dev
Shinigami92
previously approved these changes
May 27, 2021
patak-dev
previously approved these changes
May 28, 2021
antfu
previously approved these changes
May 28, 2021
nihalgonsalves
previously approved these changes
May 28, 2021
|
You're already behind a version haha, @ludofischer could you bump it to 0.12.5? |
Update esbuild to the latest 0.12 release. https://github.com/evanw/esbuild/blob/master/CHANGELOG.md Breaking changes concern CSS bundling, which Vite does not use, and changing the priority of the inject and define settings, which should have little impact since Vite only uses define.
ludofischer
dismissed stale reviews from nihalgonsalves, antfu, patak-dev, and Shinigami92
via
40d4e80
nihalgonsalves
approved these changes
May 28, 2021
Shinigami92
approved these changes
May 28, 2021
patak-dev
approved these changes
May 28, 2021
ygj6
pushed a commit
to ygj6/vite
that referenced
this pull request
Jun 1, 2021
Update esbuild to the latest 0.12 release. https://github.com/evanw/esbuild/blob/master/CHANGELOG.md Breaking changes concern CSS bundling, which Vite does not use, and changing the priority of the inject and define settings, which should have little impact since Vite only uses define.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update esbuild to the latest 0.12 release, so Vite can continue tracking esbuild changes and bug fixes.
Additional context
From what I could gather, the breaking changes in esbuild:
injectanddefinesettings,which should have little impact since Vite only uses
define.https://github.com/evanw/esbuild/blob/master/CHANGELOG.md
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).