-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add envDir
option
#3407
Conversation
question: Is this a breaking change? Do we need all to change our files from |
It's not a breaking change. See here: const envDir = config.envDir
? normalizePath(path.resolve(resolvedRoot, config.envDir))
: resolvedRoot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I see correctly, we now have no test/playground for the default case anymore
You may consider to copy the env
playground and test it specifically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shinigami92 I reverted the change to |
Okay, just spend me a 🍺 somedays if there is a regression in the future 😃 |
@Shinigami92 Deal! Just need your review approval and LGTM :) |
envDir
option
Co-authored-by: Alec Larson <[email protected]>
Close #2113
Fork of #2123 with reviewer-requested changes, branched from latest master
CC @aleclarson