-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: A static and dynamically imported module is loaded twice #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b77df1
to
0760397
Compare
Shinigami92
previously approved these changes
Apr 12, 2021
rpetersen27
commented
Apr 12, 2021
patak-dev
requested changes
Apr 13, 2021
Additionally, remove hmr
patak-dev
requested changes
Apr 13, 2021
Add additional tests that would fail otherwise
Shinigami92
reviewed
Apr 13, 2021
patak-dev
approved these changes
Apr 13, 2021
Shinigami92
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you have one static import of a module (e.g.
import foo from './foo'
) and another dynamic import of the same module (e.g.const v = 'foo; import('./${v}.js')
), the first import is used as is, but the second will have a?import
appended. Therefore, the browser interprets them as two different modules.This PR introduces a fix where the dynamic import is analyzed and only appends the "import" suffix if necessary.
Additional context
This only affected the vite-dev-server, production build worked fine.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).