fix(optimizer): ensure consistency with replace define #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
the
p3-minor-bug
Shinigami92
approved these changes
Apr 10, 2021
| @@ -227,7 +227,8 @@ export async function optimizeDeps( | |||
| 'process.env.NODE_ENV': JSON.stringify(config.mode) | |||
| } | |||
| for (const key in config.define) { | |||
| define[key] = JSON.stringify(config.define[key]) | |||
| const value = config.define[key] | |||
| define[key] = typeof value === 'string' ? value : JSON.stringify(value) | |||
There was a problem hiding this comment.
praise: TIL JSON.stringify('any-string-value') returns ""any-string-value"" 🤮
antfu
approved these changes
Apr 17, 2021
TobiasMelen
pushed a commit
to TobiasMelen/vite
that referenced
this pull request
May 3, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2893
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).