-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): don't inject queries for data URLs (fixes #2658) #2703
Conversation
I don't know why the tests would fail. |
@Shinigami92 All tests passed now. |
@patak-js Would you like to review this PR? |
We'll need @yyx990803 input here, as I don't fully understand if this change will end up affecting other parts of the system. But I think that we shouldn't be bailing out inside of |
The only place the client-side |
Sorry to bring up an old PR but it seems like this change has been reverted. Any reason why this has been done? Or is there an another way of disabling the |
@DenizUgur please create an issue with a minimal reproduction and more context of your problem, (you can link to this PR as additional info) so we can properly track your report |
Description
Make it not inject queries for data URLs.
Fixes #2658
Additional context
Appending queries to data URLs (those URLs that start with
data:
orblob:
) will break the data because data is encoded as string. This PR adds a detection for data URLs, and it will return those URLs as-is.Is this direction right?
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).