fix: Bug where short flags are ignored #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underfin
previously approved these changes
Feb 21, 2021
packages/vite/bin/vite.js
Outdated
| const debugIndex = | ||
| process.argv.indexOf('--debug') > 0 | ||
| ? process.argv.indexOf('--debug') | ||
| : process.argv.indexOf('-d') |
There was a problem hiding this comment.
How about use check --d instead of --debug? It can inlcude two case.
There was a problem hiding this comment.
That's a much better idea, didn't think of that.
There was a problem hiding this comment.
Though, actually, wouldn't that require looping through all of process.argv? indexOf is only going to return exact matches, as far as I know.
There was a problem hiding this comment.
What about this?
const debugIndex = process.argv.findIndex(arg => /^(?:-d|--debug)$/.test(arg))Also prevents false positives in case some other command line argument starts with -d.
(however, all of these implementations don't support --arg=value syntax – is that intentional?)
jonaskuske
reviewed
Feb 21, 2021
rschristian
force-pushed
the
fix/shortFlags
branch
from
472c3ee to
285d5ad
Compare
Co-authored-by: Jonas <[email protected]>
rschristian
force-pushed
the
fix/shortFlags
branch
from
285d5ad to
c882ad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure that this is the best version of the solution, but it solves an issue where the short flags for
--debugand--filterget ignored.I'm not sure if
--profileneeds the same treatment? I took a look around but didn't see where it was used, let alone if it should have a functional short flag.