Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: remove strip-ansi for a node built-in #18630

Merged
merged 2 commits into from
Nov 11, 2024
Merged

perf: remove strip-ansi for a node built-in #18630

merged 2 commits into from
Nov 11, 2024

Conversation

filipw01
Copy link
Contributor

@filipw01
Copy link
Contributor Author

I don't understand why lint is failing 😕

bluwy
bluwy approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rebuild vite to regenerate its license as there's an ordering change. I've pushed the changes here.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Nov 11, 2024
@sapphi-red sapphi-red merged commit 5182272 into vitejs:main Nov 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipw01 @bluwy @sapphi-red