fix: handle warmup glob hang #18462
Merged
fix: handle warmup glob hang #18462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
added
the
p3-minor-bug
patak-dev
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the warmup files is empty, we skip doing any globbing. It also works around SuperchupuDev/tinyglobby#65 otherwise the glob hangs the process.
I also updated
tinyglobbyas it got some fixes around supporting negating absolute patterns which was relied on by Astro.I also added
ignorefor.gitandnode_modules. It's probably unlikely someone needs to warmup those files and it's better to target your own source code as the entrypoints instead. I think it helps if the glob is./**/*.jsxtoo astinyglobby(or any other glob libraries) couldn't detect the glob parent to know not to crawl.gitornode_modules.