-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update open
dependency to 10.1.0
#18349
Conversation
|
open
dependency to 10.1.0open
dependency to 10.1.0
open
dependency to 10.1.0open
dependency to 10.1.0
I am not sure how to update the |
We didn't update in the past due to increased package size (#15421), but seems like recently it shrunk down so we could probably upgrade it again now. |
@bluwy Thanks for the explanation. That is good news. I tried fixing the issues in the lock file manually, but it seems like I don't have the right tools now. If anyone with the right setup could update the package that would be awesome. |
Seems like the dependencies are fixed now. I did another fix with how the |
open
dependency to 10.1.0open
dependency to 10.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see the shims removed!
Description
This is a fix for issue #14292 (converted to discussion #14293). I still get this error when running Vite in PowerShell (on Windows 10), which means the bug fix from the
open
dependency is not in Vite yet:In order to fix this, I upgraded the
open
package to10.1.0
inpackages/vite/package.json
(the bug was fixed in version10.0.1
). I did not find any similar PRs to upgrade this package (not even in versionv6.0.0-beta.2
), so I made this.The only breaking change going from
^8.4.2
to^10.1.0
is that node should be >=18. Vite also requires node>=18, so this should not break anything.