fix: add position to import analysis resolve exception #18344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sapphi-red
added
the
p2-nice-to-have
sapphi-red
approved these changes
Oct 12, 2024
bluwy
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While improving rollup plugin errors display on Vitest vitest-dev/vitest#6686, I noticed that the error thrown by
resolve.exportssuch asError: Missing "./xxx" specifier in "yyy" packagedoesn't have a code frame info.I added try/catch for import analysis's
this.resolveto addRollupError.pos.Screenshots before and after
Example of an error when adding
import "vite/no-such-export"toplayground/resolve.before
after