fix(css): dont remove JS chunk for pure CSS chunk when the export is used #18307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the module namespace of CSS is imported, the pure CSS chunk remover removed the JS chunk even if it should not be removed.
The import happens if
import.meta.glob
includes a CSS file.This PR makes chunks that have exports to be marked as non-pure CSS chunk.
The alternative fix is to improve the following code, but I think it would be complicated.
vite/packages/vite/src/node/plugins/css.ts
Lines 1039 to 1055 in 41735a7