Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incorrect environment consumer option resolution #18079

Merged

Conversation

dario-piotrowicz
Copy link
Contributor

Description

In the resolveEnvironmentOptions function there seem to be an expression that incorrectly resolves environment consumer options set to server to client instead:
Screenshot 2024-09-11 at 12 32 32

This PR addresses this issue

Copy link

stackblitz bot commented Sep 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@dario-piotrowicz dario-piotrowicz changed the title fix: fix incorrect environment consumer option resolution expression fix: fix incorrect environment consumer option resolution Sep 11, 2024
@dario-piotrowicz dario-piotrowicz force-pushed the dario/fix-env-consumer-resolve branch from f133b7c to a7d4617 Compare September 11, 2024 11:40
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dario!

@patak-dev patak-dev enabled auto-merge (squash) September 11, 2024 11:42
@patak-dev patak-dev disabled auto-merge September 11, 2024 11:48
@patak-dev patak-dev merged commit 0e3467e into vitejs:main Sep 11, 2024
9 of 12 checks passed
@patak-dev patak-dev added p3-minor-bug An edge case that only affects very specific usage (priority) feat: environment API Vite Environment API labels Sep 11, 2024
@dario-piotrowicz dario-piotrowicz deleted the dario/fix-env-consumer-resolve branch September 11, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: environment API Vite Environment API p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants