Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination can be off-chain #43

Closed
olanod opened this issue Jan 4, 2021 · 2 comments · Fixed by #54
Closed

Destination can be off-chain #43

olanod opened this issue Jan 4, 2021 · 2 comments · Fixed by #54

Comments

@olanod
Copy link
Member

olanod commented Jan 4, 2021

A transfer destination will not always be an account within the blockchain, it can for example be a bank account or an account in a different blockchain that a liquidity provider controls and has notified the VLN of its existence.

This means to parameter of the Transfer call should change from an AccountId to an enum type that allows other types of off-chain destinations.
e.g.

enum Destination {
    Vln(AccountId),
    Bank(DetailsId),
    Btc(BtcId),
    // ...
}
@stanly-johnson
Copy link
Member

@olanod This has been removed in the migration to v3. Is this no longer needed or should I work on integrating this back?

@olanod
Copy link
Member Author

olanod commented Mar 6, 2021

Hi Stan, it's still up for discussion but I didn't add it back since the new Multiaddress format might be just enough for representing external addresses and identifiers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants